Updating the issue tracker - part 2

[prl]

This post covers what's currently in the first 3 of six pages of issues in the issue tracker "Open" list, issue numbers #338 and greater.

Fixed or implemented:

• #338: "Jump first press" in Channel selection doesn't allow SMS-style character entry
  #344: Strange timers created from MENU>TV/Radio>Timers while watching a recording
  #361: Zombie resume points and other issues with the file resume cache Fixed as a side-effect of fixes to #537 & #538.
  #385: Allow TIMER button to access the timers list while playing a recording in Movie Player
  #413: "play as picture in picture" crashes in channel list menu
  #414: [MovieSelectionSlim] "Slim" Movie Player screen a bit of a mess
  #428: Upgrade avahi to 0.6.32 or better when it's released. Fixed as side-effect of upstream merge.
  #431: Incorrect am/pm indicators for times 12:00pm-12:59pm in Graphical EPG
  #453: Show program end time in [GraphicalEPGPIG]
  #459: Editing hostname not clean
  #462: T4 HDMI-IN Fullscreen video is blank without FTA signal on boot
  #466: IMDb spelling and grammar correction
  #467: Use "conditional" skin element attribute to reduce log clutter for button hints
  #469: HELP button inactive in EPGSearch
  #480: Zap timer fails to change channel when in media player
  #481: Zap timer over-ridden on exit from media browser
  #500: [EPGSearch] Hang on selection when Enable multiple bouquets is disabled
  #501: EPGSearch can unnecessarily change the selected bouquet
  #503: New option to restrict event searches
  #504: Unnecessarily wide field widths for date/time fields in single-channel EPG
  #523: [TimerEntry] Crash when "repeat/user defined" has no days set

Status unknown/can't test:

• #402: T2/T4 TCP Coalescing Issues with VLC and Samba under Windows Confirmed as fixed by MrQuade.

Duplicates:

• #360: HELP screens show actions for all remote devices, not just those configured duplicates #322 and is not fixed.
  #385: Allow TIMER button to access the timers list while playing a recording in Movie Player duplicates #505 and is fixed

Needs better replication information:

• #520: Start / End bookmarks missing on recordings The main part of the issue can be replicated, but it's not clear whether it can be replicated for the case where "overlapping recordings can cause bookmarks to be mishandled".

Unclear what's wanted:

• #407: Info Screen Optimisation Discussion went a bit round in circles then died off without anything seeming to be decided.

May need revision:

• #341: Search "Jump first press" is not correctly case-insensitive The underlying function says that the search starts after the current entry, but it actually searches from the start of the list, but otherwise it works correctly.
  #423: Long press REC to create ZAP timer does not set ZAP timer colour or icon Long-REC now creates a zap timer with no end time rather than one with prepadding + 1 minute duration. This also doesn't show a zap timer icon, but it's not clear quite what's wanted here.
  #482: Zap and record timer doesn't "zap" when in the media player or browser Fixed when in media browser, not fixed when in media player.
  #529: Prevent unsupported media file playback This has been improved in the upstream merge, but I'm not sure whether it should be labelled fixed, or changed to reflect the current state.

[MrQuade]

#402 has been fixed in the Alpha.

[prl]

#402 has been fixed in the Alpha.

OK, thanks.

[IanSav]

Hi Prl,

I have updated #423 to indicate that my preference for long REC would be to create a ZAP timer that runs the full event duration plus any applicable padding. That is, by default, create a ZAP timer the equivalent of a normal RECORD type timer. If the user wants a short version of the timer then they can edit the standard timer and make any changes required.

Regards,
Ian.

[MrQuade]

I have updated #243

#423?

[IanSav]

Hi MrQuade,

#423?

Corrected. Thank you.

Regards,
Ian.

[prl]

... I have updated #423 to indicate that my preference for long REC would be to create a ZAP timer that runs the full event duration plus any applicable padding. That is, by default, create a ZAP timer the equivalent of a normal RECORD type timer. If the user wants a short version of the timer then they can edit the standard timer and make any changes required. ...

Against that is peteru's view that zap timers should be as short as possible, and the upstream merge of 18f37ed [TimerEntry] hide option 'Add End Time' for ZAP timer, which prevents users from explicitly setting or modifying the end time of a zap timer.

The full text of the log message from 18f37ed is:

[TimerEntry] hide option 'Add End Time' for ZAP timer, as ZAP timer should be used as a reminder that event has started, and thus should not have a end time.

That's one way to look at it, I guess.

[IanSav]

Hi Prl,

While I agree that some people use a ZAP timer as a simple reminder I would like to suggest that some people use the ZAP style timer to start their unit and display the nominated show for the nominated length of time and then shut the unit down when the timer completes. All these "shortening" techniques break this basic timer functionality.

As I suggested earlier, if people want a reminder type timer then create a ZAP timer and then edit it to shorten or remove the end time. Even if they don't edit the timer there is no reminder functionality lost or broken if the ZAP timer runs for the appropriate duration.

I suggest that the long REC should retain the predictability and symmetry of the REC recording timer creation. The additional benefit of restoring the full duration is that the ZAP timer displays on the EPG will be automatically corrected by default if the spans are preserved.

Regards,
Ian.

[MrQuade]

While I agree that some people use a ZAP timer as a simple reminder I would like to suggest that some people use the ZAP style timer to start their unit and display the nominated show for the nominated length of time and then shut the unit down when the timer completes. All these "shortening" techniques break this basic timer functionality.

How on earth do you do that? None of the "after recording options are available when making a zap timer.

Do you create a record timer, set the parameters, then convert to a zap timer and it retails all the duration and "after event" behaviour? (if so YUCK! That's just terrible and needs fixing) Also what happens if you change channel while the zap timer is "running", does it zap back?

I'd be more on board with PeterU's suggestion of creating a "view" timer type to compliment the zap timer type. Zap is fine as it is and does its job, but I would say that a view timer type would cater for the users in the scenario you describe (though they could just set a shutdown timer too). To be honest, I was struggling to think of a purpose of a zap timer with a duration too!

[Grumpy_Geoff]

While I agree that some people use a ZAP timer as a simple reminder I would like to suggest that some people use the ZAP style timer to start their unit and display the nominated show for the nominated length of time and then shut the unit down when the timer completes. All these "shortening" techniques break this basic timer functionality.

How on earth do you do that? None of the "after recording options are available when making a zap timer.

Do you create a record timer, set the parameters, then convert to a zap timer and it retails all the duration and "after event" behaviour? (if so YUCK! That's just terrible and needs fixing) Also what happens if you change channel while the zap timer is "running", does it zap back?

You can create a Zap timer with an end time and after event action using OpenWebif. The end time and after event don't show in the GUI (unless you subsequently change the timer type).
Do any editing in the GUI and the duration is reset to 10 minutes. After event action is retained.

Same with creating a record timer in the GUI and then changing it to a zap timer, the duration is set to 10 mins.

No zapping back.

[MrQuade]

You can create a Zap timer with an end time and after event action using OpenWebif. The end time and after event don't show in the GUI (unless you subsequently change the timer type).
Do any editing in the GUI and the duration is reset to 10 minutes. After event action is retained.

Same with creating a record timer in the GUI and then changing it to a zap timer, the duration is set to 10 mins.

Yikes. That all needs a serious cleanup then.

[prl]

...
How on earth do you do that? None of the "after recording options are available when making a zap timer. ...

You can't in the alpha, but that's because of the upstream merge I mentioned. You can in the current official firmware.

Disregarding backdoor methods using Open Webif.

[IanB]

...
Against that is peteru's view that zap timers should be as short as possible, and the upstream merge of 18f37ed [TimerEntry] hide option 'Add End Time' for ZAP timer, which prevents users from explicitly setting or modifying the end time of a zap timer.

The full text of the log message from 18f37ed is:

[TimerEntry] hide option 'Add End Time' for ZAP timer, as ZAP timer should be used as a reminder that event has started, and thus should not have a end time.

That's one way to look at it, I guess.

Geez, don't you just love it when opinionated users submit spaghetti code to complicate the world.

The very original code had a "Set end time" option (yes a code complication in it's own right) that when set to "Yes" allowed Zap timers to have an "End time" and an "After event" specified. It also caused/allowed such a Zap timer to be part of a Timer tuner conflict.

And this was all very good and orthogonal.

[Grumpy_Geoff]

Hi Peter,

Do you plan on visiting the issues of 'NEW' status at some stage in the near-ish future?

I had a look at some towards the top of the list (I was checking on #491, so I thought I'd check a few more).
With the 16.1 alpha installed - 2016-11-24:

The below are still current issues -

• Issue #511 - Auto standby/deepstandby timers don't take effect when not in live TV
  (and probably its sibling Issue #510 too)
• Issue #507 - Font and number of rows changes not applied immediately in some EPG styles
• Issue #502 - Some sort changes don't work in media browser
• Issue #497 - [MovieSelection] Newly selected sort not correctly displayed in "Sort" button
• #496 - Repeated message on shutdown when more than one job is running
  (I note that changing the 'after action' for the in-progress jobs [BLUE, select job] doesn't stick)
• Issue #491 - Unnecessary delays in performing merge when saving current event's timeshift
• Issue #485 - HDMI In PiP Control not in sync with FTA PiP control
• Issue #470 - [EPGSearch] GREEN Add timer hint displayed when search list is initially empty

Partially fixed -

• Issue #482 - Zap and record timer doesn't "zap" when in the media player or browser
  The record part of the zap & record timer works in all cases.
  If media browser has a service playing in the background, the zap occurs to the timer's service.
  If media browser has no service playing in the background, the zap does not occur
  In the media player, the zap does not occur
• Issue #481 - Zap timer over-ridden on exit from media browser
  If the media browser has a service playing in the background, the zap occurs to the timer's service, EXIT remains on zapped service
  If the media browser has no background service showing, the zap does not occur. EXIT shows zapped service.

No longer an issue -

• Issue #523 - [TimerEntry] Crash when "repeat/user defined" has no days set
• Issue #501 - EPGSearch can unnecessarily change the selected bouquet
• Issue #500 - [EPGSearch] Hang on selection when Enable multiple bouquets is disabled
• Issue #480 - Zap timer fails to change channel when in media player
• Issue #469 - HELP button inactive in EPGSearch
• Issue #459 - Editing hostname not clean

Cheers,
Geoff

[prl]

Don't Updating the issue tracker - part 1 and Updating the issue tracker - part 2 cover much of what you posted here (and lots of older issues that have been fixed but which haven't been marked as fixed)?

I do need to go back to them and update the issue tracker to mark them as fixed. Perhaps in the next couple of days.

[Grumpy_Geoff]

I thought you were only tackling 'OPEN' status issues, not 'NEW' status, but I see now that you had covered some of the 'NEW' ones too.
The 'NEW' status issues were still open, so that's why I thought you hadn't looked at them.
So, yes, some overlap.
I don't think the 'part 1' issues overlap.
Some 'part 2' issues do overlap; from your list -

Fixed or implemented:
#459: Editing hostname not clean
#469: HELP button inactive in EPGSearch
#480: Zap timer fails to change channel when in media player
#481: Zap timer over-ridden on exit from media browser
- isn't fully fixed if no background service is playing
#501: EPGSearch can unnecessarily change the selected bouquet
#523: [TimerEntry] Crash when "repeat/user defined" has no days set

May need revision:
#482: Zap and record timer doesn't "zap" when in the media player or browser Fixed when in media browser, not fixed when in media player.
- not fixed in media browser if no background service playing

[prl]

I went through all the issues displayed in the issue tracker when the "Open" filter is selected. That includes issues marked as either New or Open.

[Grumpy_Geoff]

Okay, I got confused as the issues were still open.
Let's forget about this thread then.

Do you want me to comment in the part 2 thread re. the issues below -

#481: Zap timer over-ridden on exit from media browser
- isn't fully fixed if no background service is playing
#482: Zap and record timer doesn't "zap" when in the media player or browser
- not fixed in media browser if no background service playing

You hadn't listed this one, it is fixed -
Issue #500: [EPGSearch] Hang on selection when Enable multiple bouquets is disabled

Cheers
Geoff

[prl]

I might just merge the two topics.

Edit: merged now.

[prl]

... Do you plan on visiting the issues of 'NEW' status at some stage in the near-ish future? ...

By "visiting" do you mean "fixing"?

[prl]

...
...
Partially fixed -

• ...
• Issue #481 - Zap timer over-ridden on exit from media browser
  If the media browser has a service playing in the background, the zap occurs to the timer's service, EXIT remains on zapped service
  If the media browser has no background service showing, the zap does not occur. EXIT shows zapped service.

Where there's no background service showing, it's because of an explicit user preference not to show it. I'm not sure that the behaviour in that second case is wrong. I'll leave #481 marked as active for now.

...
No longer an issue -

• ...
• Issue #500 - [EPGSearch] Hang on selection when Enable multiple bouquets is disabled
  ...

Yes, #500 has been fixed.

The link for this was actually in the "fixed" list, but its text suggested it was a link to #482. Fixed now.

[prl]

I have marked all the agreed fixed issues as fixed.

I can't change the status of these fixed issues. Could peteru or the author please mark them resolved:

peteru: #428
MrQuade: #402, #462, #503

IanSav has already marked #466 as fixed.

The issue tracker now has 4 pages of pending fixes, down from 6 pages. Currently 96 pending issues.

[MrQuade]

MrQuade: #402, #462, #503

Done.

[Grumpy_Geoff]

... Do you plan on visiting the issues of 'NEW' status at some stage in the near-ish future? ...

By "visiting" do you mean "fixing"?

No, I know I don't get to decide priorities
By "visiting" I just meant looking to see if the issues still existed & closing them if not.
You were using a filter of Open, whereas I thought you were using a status of Open
I didn't know if you'd checked the others (NEW) - but you had.

I think I'm just digging a deeper hole

[prl]

MrQuade: #402, #462, #503

Done.

Thanks.

[Grumpy_Geoff]

...
...
Partially fixed -

• ...
• Issue #481 - Zap timer over-ridden on exit from media browser
  If the media browser has a service playing in the background, the zap occurs to the timer's service, EXIT remains on zapped service
  If the media browser has no background service showing, the zap does not occur. EXIT shows zapped service.

Where there's no background service showing, it's because of an explicit user preference not to show it. I'm not sure that the behaviour in that second case is wrong. I'll leave #481 marked as active for now.

I can see your point about user preference.
I don't have a service showing in the media selection screen upon return from the media player, as I don't want timeshifting on for something that just happens to be showing.

I was thinking the idea of a zap timer is to remind one that something's on (to be viewed live, or later timeshifted)? One could be in the media selection screen for quite a while before the sporting event or news broadcast (for example) started. Hearing the audio from a zapped service would alert the user - 'hey buster, here is something you wanted on'.

#482 has the same 'problem', but given it's also a record timer then at least the program wouldn't be missed.

I'm not fussed about them.