Improvements to resume points

[prl]

There is explicit code in InfoBarGenerics.getResumePoint() that prevents it from returning a resume point if the stored resume point is for a recording.

I don't see a good reason for that. I'd go as far as calling it a bug, based on the fact that the only code that calls getResumePoint() only does so when the cuesheet has no entries. That implementation looks buggy to me as well. It will not allow you to resume if the cuesheet has edit points but no resume point. Notice that I say cuesheet, rather than .cuts file. This is because there could be other sources for cuesheets, such as DVD navigation or embedded chapter marks in MKV files, etc.

I entirely agree. I was describing the current code state, not suggesting it was a good idea. It's left as it is for now, not because I like it, but because it's not ye decided what to do about it.

However, not returning valid resume points is so broken that perhaos I should remove that block from the code anyway.

...

for the current implementation, I could simply stop putting resumepoints for recordings (and .ts files) in the cache

I'd rather if you didn't. I think doing so introduces inertia in the wrong direction. ...

I haven't changed this in my current implementation of #537: Improve resume point setting performance in media player.

[prl]

I have now implemented:
Enhancement request #537: Improve resume point setting performance in media player
Enhancement request #538: Improve file tracking in the resume point cache
in the current alpha. It seems to work quite nicely. The delay on a T4 on stopping playback with simoncasey's resumepoints.pkl file (~260 entries) has dropped from ~1100ms to < 10ms, with only about 10-15% of that being the cache update. The rest of the time is for the resumepoints.pkl file write.

If peteru is interested in including it in the alpha, rather than a later beta, I'm happy to make it available as a patch for use with the current alpha. Otherwise, I'll sit on it for a bit.

I think the only possible testers at the moment are peteru, MrQuade and perhaps IanB.

[glen]

Please if possible include it in the alpha. Though I can't test it until it is available for the T3.

Really looking forward to this.

Prl, thank you for your help with this one.

Glen

[prl]

No problem. It's just going to be a matter of when it's most convenient to merge it into the firmware.

[peteru]

There are no plans to update the 4.4 series firmware, so when the feature appears it will be in the 16.1 series.

Feel free to submit the pull requests at any time. I'll have a look at what the code looks like and then merge when I'm ready.

[prl]

... Feel free to submit the pull requests at any time. ...

Done.

[prl]

My resume point performance improvements have been merged into the current alpha release. They should be in the upcoming beta and then in the next official release.

The resume point cache size is user-settable: Disabled, 100, 200, 500, 1000, 2000, 5000. The default is 1000 entries.