Startup wizard scan region and final welcome screens broken

Moderators: Gully, peteru

Post Reply
prl
Wizard God
Posts: 32712
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Startup wizard scan region and final welcome screens broken

Post by prl » Sun Aug 15, 2021 14:14

In the initial setup screens, changes made to Screens/IniTerrestrialLocation.py to make the screens in it (IniTerrestrialLocation and IniEndWizard) look more like config screens have broken the description text in the location scan selection ("Please select your location and then press OK to begin the scan. ...") and in the final "setup done" screen ("Congratulations, your Beyonwiz XN is now set up. ...") and nothing is displayed in the boxes that should contain the text.

The change to IniTerrestrialLocation should have had corresponding changes in the skin files for the skins for IniTerrestrialLocationWizard as well as for IniTerrestrialLocation, or it should have been left as it was.

IniEndWizard should not have been changed in Screens/IniTerrestrialLocation.py - it's a Wizard, not a config screen.

Replication: do a factory reset and pay attention to the instructions in the frames.

The broken screens...

Location scan selection screen:

screenshot_20210815141917.jpg

"Setup done" screen:

screenshot_20210815142108.jpg
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
peteru
Uber Wizard
Posts: 9741
Joined: Tue Jun 12, 2007 23:06
Location: Sydney, Australia
Contact:

Re: Startup wizard scan region and final welcome screens broken

Post by peteru » Sun Aug 15, 2021 23:03

Good catch!

This is definitely something that should be fixed before the beta is promoted to release candidate and then goes official.

"Beauty lies in the hands of the beer holder."
Blog.

prl
Wizard God
Posts: 32712
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: Startup wizard scan region and final welcome screens broken

Post by prl » Mon Aug 16, 2021 11:49

I've coded a fix and I'm testing it. I should have a pull request ready later today.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32712
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: Startup wizard scan region and final welcome screens broken

Post by prl » Mon Aug 16, 2021 12:21

While I'm messing about with this, is there a good reason why the selection lists for the timezone country and zone shouldn't have the same smaller itemHeight (item spacing) as the service scan region list?
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32712
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: Startup wizard scan region and final welcome screens broken

Post by prl » Mon Aug 16, 2021 13:19

Pull request submitted.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32712
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: Startup wizard scan region and final welcome screens broken

Post by prl » Mon Aug 16, 2021 16:42

prl wrote:
Mon Aug 16, 2021 12:21
While I'm messing about with this, is there a good reason why the selection lists for the timezone country and zone shouldn't have the same smaller itemHeight (item spacing) as the service scan region list?

I've submitted a pull request for that, too.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Post Reply

Return to “Bug Reporting and Feature Requests”