Folder icon overlay on User - bouquets (TV) screen

Pete123 · Post by **Pete123** » Fri Jan 24, 2020 18:21

Came across a graphic overlay issue on a T4 with firmware 20190818

From live TV
Press MENU
Press Channels
Press Menu
Press EXIT

I then see folder icons overlaid on the bouquet list:

: 005F9B71-6B69-411D-8C25-E3D43DEE4880.jpeg (71.69 KiB) Viewed 5532 times

MrQuade · Post by **MrQuade** » Fri Jan 24, 2020 19:42

Can't reproduce on the default skin.

It looks like you are using overlayHD, so you are probably SOL. IanSav is no longer maintaining this skin until the Beyonwiz firmware is in line with OpenVix.

BTW, an easier way to get to that screen is FAV->BLUE

IanSav · Post by **IanSav** » Fri Jan 24, 2020 20:39

Hi,

This skin is *not* OverlayHD. It looks like Full Metal Wizard.

Regards,
Ian.

Pete123 · Post by **Pete123** » Fri Jan 24, 2020 20:39

MrQuade wrote: ↑
Fri Jan 24, 2020 19:42
Can't reproduce on the default skin.

It looks like you are using overlayHD, so you are probably SOL. IanSav is no longer maintaining this skin until the Beyonwiz firmware is in line with OpenVix.

BTW, an easier way to get to that screen is FAV->BLUE

It’s actually Full Metal Wizard, but it looks like OverlayHD because I’ve taken the screenshot as OSD only and so it looks like there’s no transparency.

Thanks for the shortcut tip. I use a Harmony remote and don’t have FAV mapped, and I’ve forgotten what extra buttons are on the original remote!

I’ll try changing skins tomorrow (recording tonight) and I’ll test again and report back.
I’ll also update to latest firmware in case it’s been fixed.

MrQuade · Post by **MrQuade** » Fri Jan 24, 2020 20:42

IanSav wrote: ↑
Fri Jan 24, 2020 20:39
This skin is *not* OverlayHD. It looks like Full Metal Wizard.

Ahh, my mistake. Leapt to a conclusion based on different button icons. I exclusively use the default skin.

Should be a chance to fix that then.

MrQuade · Post by **MrQuade** » Fri Jan 24, 2020 20:47

Pete123 wrote: ↑
Fri Jan 24, 2020 20:39
Thanks for the shortcut tip. I use a Harmony remote and don’t have FAV mapped, and I’ve forgotten what extra buttons are on the original remote!

Mine is mapped to a long press of GUIDE. Handy to have it available as a quick access screen.

MrQuade · Post by **MrQuade** » Fri Jan 24, 2020 21:34

I can't reproduce on FullMetal either btw. (Sorry, couldn't check till I was home).

IanSav · Post by **IanSav** » Fri Jan 24, 2020 23:24

Hi,

With the proliferation of patches to the Beyonwiz firmware it is probably important to know *exactly* how each machine is configured and patched before trying to resolve issues.

Regards,
Ian.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 00:59

I've used FMW since I got the T2 and never seen that (and still haven't); it's also never appeared on the V2.

MrQuade wrote: ↑
Fri Jan 24, 2020 19:42
BTW, an easier way to get to that screen is FAV->BLUE

FAV > FAV is even easier.

MrQuade · Post by **MrQuade** » Sat Jan 25, 2020 02:10

adoxa wrote: ↑
Sat Jan 25, 2020 00:59
FAV > FAV is even easier.

True!

(though not so much for me since FAV is a long-press action)

Pete123 · Post by **Pete123** » Sat Jan 25, 2020 10:58

I’ve now updated the firmware to latest (20191106) and if I don’t restore settings, the problem is gone. If I restore settings, the problem reappears.

So, it sounds like it’s something peculiar just to my setup. Since it occurs on both of my T4s, it’s likely not a corrupted config. And it’s not skin dependant, as it appears on both supplied skins.

I use EPGRefresh and adoxa’s YourTV script.

It’s a very minor issue and probably only affecting me, but I’ll still spend some time to see if I can find what triggers it by changing settings one at a time from a fresh install, and installing the two extras mentioned above.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 11:03

If you wouldn't mind posting your backup/settings I could see if it affects the test V2.

Pete123 · Post by **Pete123** » Sat Jan 25, 2020 15:37

adoxa wrote: ↑
Sat Jan 25, 2020 11:03
If you wouldn't mind posting your backup/settings I could see if it affects the test V2.

Here's my T4 settings backup that has the issue.

From my testing so far - from a fresh clean install, I've changed to FMW and added EPGRefresh and YourTV.
No problems yet.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 16:03

Restored that on the V2 and yep, the icons go awry after exiting from the menu. Curious...

Pete123 · Post by **Pete123** » Sat Jan 25, 2020 16:25

Ok, I’ve found the setting...

From live tv
Menu
Setup
TV
Channel selection
Show event-progress in channel list ——> Change to: Progress bar left

prl · Post by **prl** » Sat Jan 25, 2020 16:42

MrQuade wrote: ↑
Fri Jan 24, 2020 20:42

IanSav wrote: ↑
Fri Jan 24, 2020 20:39
This skin is *not* OverlayHD. It looks like Full Metal Wizard.
Ahh, my mistake. Leapt to a conclusion based on different button icons. I exclusively use the default skin.

OverlayHD uses other other button icons

The OverlayHD buttons are distinguished by a grey frame around each button.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 16:51

Pete123 wrote: ↑
Sat Jan 25, 2020 16:25
From live tv

Or MENU > MENU from within the list itself.

Show event-progress in channel list ——> Change to: Progress bar left

Huh, apart from "No" they're all broken, the left ones are just more noticeable.

prl · Post by **prl** » Sat Jan 25, 2020 17:06

Pete123 wrote: ↑
Sat Jan 25, 2020 16:25
Ok, I’ve found the setting...

From live tv
Menu
Setup
TV
Channel selection
Show event-progress in channel list ——> Change to: Progress bar left

I can't replicate the problem in firmware 20191106 by just changing that setting on any of the three skins: easy-skin-aus-hd, Full-Metal-Wizard or OverlayHD.

Changing the setting to Percentage left doesn't cause the problem, either.

The positioning of the elements in a channel selection screen line are done in the code, rather than in the skin, though some parameterisation is possible in the skin.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 17:15

You need to enter/exit the menu. With the setting other than "No": FAV to bring up the channel list, again to show the bouquets, MENU to show the menu, EXIT back to the list, and now the bouquet list is displayed incorrectly - press FAV/BLUE again to restore.

prl · Post by **prl** » Sat Jan 25, 2020 17:50

adoxa wrote: ↑
Sat Jan 25, 2020 17:15
You need to enter/exit the menu. With the setting other than "No": FAV to bring up the channel list, again to show the bouquets, MENU to show the menu, EXIT back to the list, and now the bouquet list is displayed incorrectly - press FAV/BLUE again to restore.

OK, I can replicate it that way, but for me the effect is transitory. If I get the munged favorites list, as soon as I exit the channel selection screens and go back, the problem has gone away.

That's not to say that something isn't broken, but I can't seem to make it a permanent problem.

Grumpy_Geoff · Post by **Grumpy_Geoff** » Sat Jan 25, 2020 17:54

adoxa wrote: ↑
Sat Jan 25, 2020 16:51
Huh, apart from "No" they're all broken, the left ones are just more noticeable.

I have 'Percentage right' and I don't see the issue.

Edit - maybe because I have my UI resized?

IanSav · Post by **IanSav** » Sat Jan 25, 2020 18:04

Hi Prl,

prl wrote: ↑
Sat Jan 25, 2020 17:50

adoxa wrote: ↑
Sat Jan 25, 2020 17:15
You need to enter/exit the menu. With the setting other than "No": FAV to bring up the channel list, again to show the bouquets, MENU to show the menu, EXIT back to the list, and now the bouquet list is displayed incorrectly - press FAV/BLUE again to restore.
OK, I can replicate it that way, but for me the effect is transitory. If I get the munged favorites list, as soon as I exit the channel selection screens and go back, the problem has gone away.

That's not to say that something isn't broken, but I can't seem to make it a permanent problem.

I can also reproduce column alignment issues with this procedure. I can also see the same issue on OpenViX. I haven't tested OpenPLi as I am doing something on OpenViX at the moment.

By the way, OverlayHD has a number of button display options. Not all of them have the grey background.

Regards,
Ian.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 18:06

When you first bring up the bouquet list have a close look at the left - the highlight and folder icon are aligned. Press MENU/EXIT. Have another look, you should see the icon has shifted across. Press BLUE or FAV and they'll shift back.

It also happens on OpenATV. The issue seems to be when you exit the menu it sets the mode to MODE_TV, irrespective of what the current mode is. I've commented that out and am about to test it...

Pete123 · Post by **Pete123** » Sat Jan 25, 2020 18:07

Grumpy_Geoff wrote: ↑
Sat Jan 25, 2020 17:54

adoxa wrote: ↑
Sat Jan 25, 2020 16:51
Huh, apart from "No" they're all broken, the left ones are just more noticeable.

I have 'Percentage right' and I don't see the issue.

Edit - maybe because I have my UI resized?

And I only see it with progress bar left or percentage left. All others are okay.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 18:14

Right is okay, but still not right (heh). The icon doesn't overlay the text, as the whole lot shifts.

Commenting out that line seems to have fixed it without issue, about to submit pull request.

prl · Post by **prl** » Sat Jan 25, 2020 18:15

Pete123 wrote: ↑
Sat Jan 25, 2020 18:07

Grumpy_Geoff wrote: ↑
Sat Jan 25, 2020 17:54

adoxa wrote: ↑
Sat Jan 25, 2020 16:51
Huh, apart from "No" they're all broken, the left ones are just more noticeable.

I have 'Percentage right' and I don't see the issue.

Edit - maybe because I have my UI resized?

And I only see it with progress bar left or percentage left. All others are okay.

Like adoxa, I also see it with both left and right. It's more noticeable with left because the folder icon overlays the text, but with the setting "right", the folder is displaced right (it should be hard up against the left of the column), but the text is displaced right by the same amount, so it isn't as obvious.

IanSav · Post by **IanSav** » Sat Jan 25, 2020 18:18

Hi,

OpenPLi is a little different in may areas from OpenViX, Beyonwiz etc. That said, OpenPLi does not suffer this issue.

Regards,
Ian.

adoxa · Post by **adoxa** » Sat Jan 25, 2020 18:24

Here's the patch.

Pete123 · Post by **Pete123** » Sat Jan 25, 2020 19:44

adoxa wrote: ↑
Sat Jan 25, 2020 18:24
Here's the patch.

Thanks for the fix

MrQuade · Post by **MrQuade** » Sat Jan 25, 2020 19:50

Still can't reproduce the problem here. Not sure what's different on my setting. I normally have mine set to progress bar right, but setting to progress bar left, openining FAV->FAV->MENU->EXIT doesn't do anything bad.

Huevos · Post by **Huevos** » Sat Jan 25, 2020 19:50

That patch breaks hidden markers. Is that what you wanted to do?

adoxa · Post by **adoxa** » Sat Jan 25, 2020 21:59

I don't know what hidden markers are. OpenATV mentions something about it and has setHideNumberMarker, but Beyonwiz doesn't have that.

MrQuade · Post by **MrQuade** » Sat Jan 25, 2020 23:31

adoxa wrote: ↑
Sat Jan 25, 2020 21:59
I don't know what hidden markers are. OpenATV mentions something about it and has setHideNumberMarker, but Beyonwiz doesn't have that.

Does he mean a bouquet "Spacer"?
As opposed to a visible dummy line called a "Marker"?

Huevos · Post by **Huevos** » Sun Jan 26, 2020 00:21

The patch breaks visible and hidden markers. In move mode visible markers become visible. On exiting move mode they should disappear again. This patch breaks that behaviour.

If Beyonwiz does not have visible markers something is wrong.

Huevos · Post by **Huevos** » Sun Jan 26, 2020 00:30

Also you are removing one part of a whole commit. If you want to wreck visible markers you should remove all the dead code created by removing this one line.

MrQuade · Post by **MrQuade** » Sun Jan 26, 2020 01:24

Huevos wrote: ↑
Sun Jan 26, 2020 00:21
If Beyonwiz does not have visible markers something is wrong.

It does have them. Your earlier terminology of "invisible markers" was misleading adoxa I think. They are called Spacers in the web interface.

He didn't mean to break the markers, it would have been an unintended consequence of the change.

Huevos · Post by **Huevos** » Sun Jan 26, 2020 04:09

By the look of it the code comments were deleted by whoever added this to Beyonwiz.

This code goes back about 8 years but if you want to see the whole thing as a single commit have a look at my repo.

https://github.com/Huevos/enigma2/commi ... 51460ae5e0

adoxa · Post by **adoxa** » Sun Jan 26, 2020 12:52

Beyonwiz does not have the "hide markers" option, so I cannot see how I can have broken it. Markers (as in "Add marker") and spacers (as used by the terrestrial LCN list) are unaffected.

Huevos · Post by **Huevos** » Mon Jan 27, 2020 11:48

The purpose of that line is to reload after the font sizes and number of rows has been changed by the user.

https://github.com/OpenViX/enigma2/comm ... cbfa9d0ab2

Huevos · Post by **Huevos** » Mon Jan 27, 2020 11:51

Also, if you can't hide visible markers you have missing code.

adoxa · Post by **adoxa** » Mon Jan 27, 2020 12:19

Huevos wrote: ↑
Mon Jan 27, 2020 11:48
The purpose of that line is to reload after the font sizes and number of rows has been changed by the user.

I'd think it's reasonable to assume that l.setFontSize() and l.setItemsPerPage() do that (I did test rows, but not font). Setting MODE_TV when it should be MODE_NORMAL is a bug; if my solution doesn't work on OpenVix, that's OpenVix' problem.

Huevos wrote: ↑
Mon Jan 27, 2020 11:51
Also, if you can't hide visible markers you have missing code.

If it's as old as you say I'd expect Beyonwiz doesn't want it (before my time).

IanSav · Post by **IanSav** » Mon Jan 27, 2020 15:19

Hi Adoxa,

The Beyonwiz firmware is full of holes and missing code due to merge issues and inconsistencies. Beyonwiz is now very far behind the OpenViX firmware upon which it is based. The firmware is long overdue for an upstream merge.

Regards,
Ian.

About the Forum

Join us