File Commander crash when editing non-editable line

[Grumpy_Geoff]

I caused a crash in File Commander whilst attempting to edit a non pure-text line with the GREEN/Edit button. The intention was to just view the line from a recording's .eit file.
It appears the plugin wanted to output the message -
"Error..."
"This line is not editable!".

Code: Select all

{918}<  9831.565> KEY: 388 make KEY_TEXT ('TEXT',)
{918}<  9831.566> [ActionMap] skipping showText (InfobarActions)
{918}<  9831.566> [ActionMap] calling startTeletext (InfobarTeletextActions)
{918}<  9831.568> [Skin] processing screen vEditor:
{918}<  9831.585> [Skin] processing screen SimpleSummary:
{918}<  9831.586> [SCREENNAME]  ['vEditor_summary', 'SimpleSummary']
{918}<  9831.587> [SCREENNAME]  vEditor
{920}<  9831.601> [eTextPara] unicode U+5525 not present
{920}<  9831.601> [eTextPara] unicode U+   6 not present
{918}<  9831.728> KEY: 388 break KEY_TEXT ('TEXT',)
{918}<  9839.234> KEY: 399 make KEY_GREEN ('GREEN',)
{918}<  9839.400> KEY: 399 break KEY_GREEN ('GREEN',)
{918}<  9839.400> [ActionMap] calling green (ColorActions)
{918}<  9839.402> Traceback (most recent call last):
{918}<  9839.402>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 60, in action
{918}<  9839.402>   File "/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/addons/type_utils.py", line 153, in editLine
{918}<  9839.402>   File "/usr/lib/enigma2/python/mytest.py", line 336, in open
{918}<  9839.403>     raise RuntimeError("modal open are allowed only from a screen which is modal!")
{918}<  9839.403> RuntimeError: modal open are allowed only from a screen which is modal!
{918}<  9839.403> [ePyObject] (CallObject(<bound method HelpableActionMap.action of <Components.ActionMap.HelpableActionMap instance at 0xac9b6030>>,('ColorActions', 'green')) failed)

It occurs in 20190818 and later firmwares. I don't have anything earlier to test with.

[Grumpy_Geoff]

I see the pull request

Thanks.

[adoxa]

Fix submitted (although since you replied before I did that seems redundant). Maybe I should submit my hex dump?

[Grumpy_Geoff]

Maybe I should submit my hex dump?

Yep, that could be handy.