V2: Add To Favorites Unwell

[billyblue]

Just updated my V2 to 20190802. Did a restore settings after, though looks like I forgot to do a backup immediately before, though there was an older one...

Noticed that World Movies wasn't in Favorites any more.

Went in via Menu/Channels/Terrestial TV LCN - not there either.

Decided a Factory reset was needed.

After the rescan WM was now present in the full list.

Highlighted and pressed the Green "Add to Favorites" button. Got a new screen that I haven't seen before... "Terrestrial - Services" or "Current Transponder". Either can be selected and expand to the full list or just the services on the currently selected transponder. The Green button does not have a caption on either screen.

Went back to the full list and was able to add channels via Menu & 7 (or highlighting Add to Favorites and pressing OK)

Something else that may be related: When in Favorites the Green button is captioned Delete but doesn't...

Also: A working Return button would be useful - for most of the above Exit took me out of the menu altogether.

[Grumpy_Geoff]

Yep, it brings up a satellites bouquet (?) screen.

Dud_add2Favourites.png (88.13 KiB) Viewed 1898 times

Once you add one entry (via MENU>>7/Add to Favorites), if you then restart the GUI the GREEN/Add to Favourites button works as expected (as does GREEN/Remove entry).
Perhaps the bug manifests itself if the UI is started with an empty userbouquet.favourites.tv file?

[billyblue]

Perhaps the bug manifests itself if the UI is started with an empty userbouquet.favourites.tv file?

No, trying to add a (shudder) shopping channel to my now populated favorites still brings up the satellites bouquet screen - unless the BW is trying to save me

[Grumpy_Geoff]

Perhaps the bug manifests itself if the UI is started with an empty userbouquet.favourites.tv file?

No, trying to add a (shudder) shopping channel to my now populated favorites still brings up the satellites bouquet screen - unless the BW is trying to save me

But have you restarted the UI since adding at least one entry to Favourites?
The behaviour I experienced was -

• Favourites bouquet was empty as UI startup
  • Attempt to add services via GREEN/Add to Favourites fails
  • Whereas adding services via MENU>>7/Add to Favorites is successful
  • GREEN/Remove entry fails
• If the UI is started with a non-empty Favourites bouquet
  • Adding services via GREEN/Add to Favourites succeeds
  • GREEN/Remove entry also succeeds

[billyblue]

But have you restarted the UI since adding at least one entry to Favourites?

Yes.

Leaving aside what happened before the factory reset the sequence I've followed unsuccessfully was

Green/Add (failure)
Add using menu/7 (success)

Power off.

- Hour or so for lunch then initial post followed by GG's post.

Power on.

Try to add using Green button. (failure)

Restart GUI.

Try to add using Green button again. (failure)

- Didn't check Green/Remove.

[Grumpy_Geoff]

Restart GUI.

Try to add using Green button again. (failure)

Okay, perhaps a difference between your 20190802 and my 20190811 then.

[billyblue]

Also happening on my U4 with 20190815 - Green button Add to Favorites & Delete not working.

[Grumpy_Geoff]

Also happening on my U4 with 20190815 - Green button Add to Favorites & Delete not working.

Works for me on 20190215 on my T4 -
Green button "Add" text changes to blank after the add succeeds.
Green button "Remove" works too.

I just then updated the U4 and I find the same as you (and what I observed on the T4 when factory reset) - GREEN no workie.

[adoxa]

It seems something has upset the priority, so GREEN is calling the base satellite function, rather than the main favourites function. Explicitly setting the priority to -1 seems to fix it, but I'll see if I can track down what's happened.

[adoxa]

I think it may only ever have been luck that it worked in the first place. I'm not sure of the best way to fix it: just add the -1 priority; or drop the key from the actionmap and just rename addToFav to showSatellites, creating an override? I'm a bit wary of the latter, so the former is probably the way to go.

[peteru]

Not enough context to advise...

[adoxa]

ChannelSelectionBase has context ChannelSelectBaseActions to provide action and function showSatellites. I added that context and action to ChannelSelect, but using function addToFav. Both maps have default priority. Something changed between 20190718 and 20190802, in which addToFav is no longer called, the base showSatellites is. There are two ways to restore the favourites function: explicitly give the ChannelSelect map a priority of -1, giving it precedence over the base; or remove the context and action from the map, providing a ChannelSelect override of showSatellites. (BTW, using ColorActions and green won't work, as that's on break, whereas base is on make, so still has precedence.) Actually, there may even be a third solution, removing the showSatellites action from base.

[peteru]

Thanks for that.

From a purely API driven view point, I'd prefer to see the use of the priority option to coerce the correct behaviour.

Changing the ActionMaps set up by other code smacks of trouble down the line.

[adoxa]

Changing the ActionMap (in ChannelSelection) is what I did, though, so that seems like conflicting advice; I believe "down the line" is where we're at now. Perhaps I'm overthinking it. I suspect restoring the map and overriding showSatellites would be the more correct solution, but I'll just change the priority, as the new function is more meaningful.

[adoxa]

Highlighted and pressed the Green "Add to Favorites" button. Got a new screen that I haven't seen before... "Terrestrial - Services" or "Current Transponder".

Fix submitted.

Edit: Merged and updated. Wow, that was quick!

[billyblue]

U4 & V2 updated to latest beta - all good now. Thanks.