OpenWebif missing 'Check for uniqueness in'

Moderators: Gully, peteru

Post Reply
User avatar
Draadnor
Apprentice
Posts: 35
Joined: Sat Mar 10, 2018 12:24

OpenWebif missing 'Check for uniqueness in'

Post by Draadnor » Mon Jul 15, 2019 18:43

Hi,

Recently Grumpy_Geoff mentioned a feature in AutoTimers where you select 'Require description to be unique' to be 'On any service' and then the following option appears 'Check for uniqueness in' to 'Title and all descriptions'. This works when editing AutoTimers on the U4 but the 'Check for uniqueness in' option doesn't appear in OpenWebif.

Due to how much easier it is to fine tune AutoTimers using OpenWebif, can this be added to it?

Software: beyonwiz 17.5.20190207 (17.5-819-gdd3f1fa) on the U4.

Cheers,

Peter
BeyonWiz U4 (MAR2018)
Altech PVR9600T (retired)
Topfield MP5000 (retired)

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: OpenWebif missing 'Check for uniqueness in'

Post by Grumpy_Geoff » Mon Jul 15, 2019 20:40

Check for uniqueness in value of 'Title and all descriptions' is the default.

User avatar
Draadnor
Apprentice
Posts: 35
Joined: Sat Mar 10, 2018 12:24

Re: OpenWebif missing 'Check for uniqueness in'

Post by Draadnor » Tue Jul 16, 2019 05:49

Grumpy_Geoff wrote:
Mon Jul 15, 2019 20:40
Check for uniqueness in value of 'Title and all descriptions' is the default.
Thanks for this. Would still be nice if it displayed.
BeyonWiz U4 (MAR2018)
Altech PVR9600T (retired)
Topfield MP5000 (retired)

prl
Wizard God
Posts: 32703
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: OpenWebif missing 'Check for uniqueness in'

Post by prl » Tue Jul 16, 2019 11:05

Draadnor wrote:
Mon Jul 15, 2019 18:43
Hi,

Recently Grumpy_Geoff mentioned a feature in AutoTimers where you select 'Require description to be unique' to be 'On any service' and then the following option appears 'Check for uniqueness in' to 'Title and all descriptions'. This works when editing AutoTimers on the U4 but the 'Check for uniqueness in' option doesn't appear in OpenWebif.

Due to how much easier it is to fine tune AutoTimers using OpenWebif, can this be added to it?

This appears to be a generic problem with OpenWebif and settings whose appearance is conditional on another setting.

For example, in the TV screen GUI, in MENU>Setup>Syetem>Time settings, when "Sync time using" is set to "NTP (Internet)", the "NTP server" and "NTP update interval" settings are displayed. When "Sync time using" is set to "TV broadcast" the NTP settings are not shown. In Open Webif, the NTP settings are never shown in Settings>Time.

Similarly, in the TV screen GUI, in MENU>Setup>Software manager>Configure update check, if "Background check" is enabled, the "Check every" setting is displayed. If it's disabled, "Check every" isn't shown. In Open Webif, "Check every" is never shown in Settings>Online update check settings.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: OpenWebif missing 'Check for uniqueness in'

Post by Grumpy_Geoff » Tue Jul 16, 2019 14:51

Draadnor wrote:
Tue Jul 16, 2019 05:49
Grumpy_Geoff wrote:
Mon Jul 15, 2019 20:40
Check for uniqueness in value of 'Title and all descriptions' is the default.
Thanks for this. Would still be nice if it displayed.

Agreed, but I've currently got 110 AutoTimer definitions, and I've only had to change 'Check for uniqueness in' ('searchForDuplicateDescription') twice.

One definition is for a start match on "2019 FORMULA 1"
The program has no short description, only an extended description.
A title/all descriptions uniqueness check generates a timer for the repeat, even if the completed timer exists.
A title/short description uniqueness check doesn't generate a 2nd timer.
(actually, for this one I can just use a title only restriction, as the location is in the program name).

The other definition is for "The Heights".
The program has a short description and no extended description.
The results are the same as above.

For AutoTimer comparison purposes, if the EPG event has an extended description but no short description, then the extended description is also used for the short description.
I think there's an AutoTimer code bug when it goes on to comparing extended descriptions.
The bug manifests when comparing the EPG event and an existing timer, if the short description (and title) matches as timers only have one description.
I think the code should assign 'retValue = True' before evaluating the non-null values of extdesc1 and extdesc2.
https://github.com/oe-alliance/enigma2- ... er.py#L837

'Check for uniqueness in'/'searchForDuplicateDescription' values -
Title/0
Title and Short description/1
Title and all descriptions/2

Code: Select all

					if foundShort:
						if timer.searchForDuplicateDescription == 2:
						this => retValue = True
							if extdesc1 and extdesc2:
								# Some channels indicate replays in the extended descriptions
								# If the similarity percent is higher then 0.7 it is a very close match
								retValue = ( 0.7 < SequenceMatcher(lambda x: x == " ",extdesc1, extdesc2).ratio() )
						else:
							retValue = True
-or- even this, get rid of the else clause on if timer.searchForDuplicateDescription == 2::

Code: Select all

					if foundShort:
						this => retValue = True
						if timer.searchForDuplicateDescription == 2:
							if extdesc1 and extdesc2:
								# Some channels indicate replays in the extended descriptions
								# If the similarity percent is higher then 0.7 it is a very close match
								retValue = ( 0.7 < SequenceMatcher(lambda x: x == " ",extdesc1, extdesc2).ratio() )

Post Reply

Return to “Bug Reporting and Feature Requests”