IanSav wrote: ↑Mon Jul 16, 2018 02:20Also, would you consider changing the MENU button menu structure to match that used by the MovieSelection layout? That is, make all the numeric functions an entry in a menu triggered by the MENU button and have the first item of that menu be "Settings..." to take the use to the configuration settings. (The direct access to the numeric functions should be retained.)
MrQuade wrote: ↑Wed Jul 18, 2018 23:20How about about simply "Run ffprobe (ffmpeg must first be installed)"
Or even just "(requires ffmpeg)" if you need it really short. Anyone who needs the command will know what needs doing.
I also interpreted the screenshot wording as if the option would install ffmpeg on the users behalf.
IanSav wrote: ↑Thu Jul 19, 2018 01:34Hi Prl,
An alternative could be to have option 7 read "Install ffprobe option" if the package is not installed and change the message to "Run ffprobe command" when it is available. The actions are clearly defined and automatically adjust to fit the context. There should be no unexpected pop ups or ambiguity in the option messages with this arrangement.
Regards,
Ian.
Code: Select all
diff --git a/lib/python/Plugins/Extensions/FileCommander/addons/key_actions.py b/lib/python/Plugins/Extensions/FileCommander/addons/key_actions.py
index 40ef9c4f3..303b4ad83 100755
--- a/lib/python/Plugins/Extensions/FileCommander/addons/key_actions.py
+++ b/lib/python/Plugins/Extensions/FileCommander/addons/key_actions.py
@@ -348,6 +348,8 @@ class key_actions():
testFileName = filename.lower()
_, filetype = os_path_splitext(testFileName)
longname = sourceDir + filename
+ if not fileExists(longname):
+ return
print "[Filebrowser]: " + filename, sourceDir, testFileName
if filetype == ".ipk":
self.session.openWithCallback(self.onFileActionCB, ipkMenuScreen, self.SOURCELIST, self.TARGETLIST)
Code: Select all
/usr/share/enigma2/easy-skin-aus-hd/skin.xml.bak
/usr/share/enigma2/OverlayHD/skin_filemanagers.xml.bak
/usr/share/enigma2/Full-Metal-Wizard/skin.xml.bak
/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/plugin.pyo.bak
/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/addons/key_actions.pyo.bak
Here's mediainfo for the T series (tested on T2) and U4 (untested). For those without a command line the simplest way to test might be to move/link it to /usr/bin/file or ffprobe (whichever one you don't have) and use that in File Commander (the mediainfo command is commented out).
Submitted. I've also added LEFT/RIGHT as page up/down and CH+/- as first/last page (matching File Commander's viewer).
I would like to change the navigation buttons to match the refactored Setup navigation. We need a unified approach to screen navigation.
Code: Select all
{737}< 151.627> KEY: 139 make KEY_MENU ('MENU',)
{737}< 151.627> [ActionMap] MenuActions menu
{737}< 151.690> [Skin] No skin to read...
{737}< 151.691> [Skin] processing screen <embedded-in-'FileCommanderContextMenu'>:
{737}< 151.691> [GUISkin] warning, skin is missing element menu in <class 'Plugins.Extensions.FileCommander.plugin.FileCommanderContextMenu'>
That should work, I think you'll just lose the scrollbar fix.Grumpy_Geoff wrote: ↑Sat Jul 28, 2018 12:20Assuming no other File Commander changes were in the update, should I just reinstall the "contextmenu-installer" alpha patch until this is fixed?
I forgot to issue pull requests for the matching skin changes for the context menu. I have done that now (including a pull request for Overlay).
Not a problem. Quick replies is a problem when you spend lots of time on the forum.
Constrained heights would be a problem.prl wrote: ↑Sat Jul 28, 2018 13:21The downside of using a single TemplatedMultiContent for both lines of the heading is that then both lines must have the same height.
I was proposing only using the TemplatedMultiContent for the file status information, with a two-line-high Label for the file path.
The big advantage of the TemplatedMultiContent is that the extra attributes can be programatically made available for each file item but the skin designer can choose which of those items they wish to use.prl wrote: ↑Sat Jul 28, 2018 13:21Using 4 Labels, one for the file path and one each for file size, file modification time and file mode gives the greatest layout flexibility.
Both the TemplatedMultiContent methods and the 4-Label method require changes in both the code and skin to add more fields, but I don't think it's a great idea to try to make the header fields replacements for the file status popup.
