FileCommander.Inputmod & InputBoxmod

Moderators: Gully, peteru

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Sat Jul 28, 2018 13:48

Hi Prl,
prl wrote:
Sat Jul 28, 2018 13:44
What about Label for the file path and TemplatedMultiContent for the file status info? I think that gives the best compromise between layout flexibility and skin selection of fields without unwanted height constraints.
Sorry I was not clear in my last post. You have interpreted what I intended to say exactly as I had intended.

A 2 line label for the file name and a TemplatedMultiContent for the range of file attributes that are to be displayed. The skinner can choose to use as few or as many attributes across the one line as they want.

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 13:53

OK, I'm happy to go with that.

Adoxa, for the file mode, I'm happy to go with either a 4-digit zero-filled octal mode or to drop the octal mode from the headers. I don't think that suppressing leading zeros is an appropriate octal format for a bit field. The information in the most significant octal digit is displayed in the symbolic mode, and so it should be unambiguously displayed in the octal mode.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Sat Jul 28, 2018 14:11

prl wrote:
Sat Jul 28, 2018 13:53
Adoxa, for the file mode, I'm happy to go with either a 4-digit zero-filled octal mode or to drop the octal mode from the headers.
If you're going to add some of the extra stuff that IanSav suggested, dropping the octal mode would free up more space; if not, keep it and I can live with four digits...
prl wrote:
Sat Jul 28, 2018 11:13
It's the same representation used in the file info popup, and on-one mentioned that as an issue.
...or I can do what I just did and make my personal version use three. ;)

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 14:48

adoxa wrote:
Sat Jul 28, 2018 14:11
prl wrote:
Sat Jul 28, 2018 11:53
I think that the ls -l style mode info makes it clearer that it is the mode, at least for people familiar with the U*ix ls command.
If you're going to go that style, how about combining it like ls does:
The permissions listed are similar to symbolic mode specifications
(*note Symbolic Modes::). But `ls' combines multiple bits into the
third character of each set of permissions as follows:
`s'
If the setuid or setgid bit and the corresponding executable
bit are both set.

`S'
If the setuid or setgid bit is set but the corresponding
executable bit is not set.
...

I do already. Try it in the file status popup (the header uses the same code). E.g this contrived example:
Screen Shot 2018-07-28 at 14.45.26.png
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Sat Jul 28, 2018 14:51

Yep, you just beat me to my edit. :)

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 14:51

Does this tuple (in the return statement) give enough flexibility for a TemplatedMultiContent file status line?

Code: Select all

		# Numbers in trailing comments are the template text indexes
		symbolicmode = fileModeStr(st.st_mode)
		octalmode = "%04o" % stat.S_IMODE(st.st_mode)
		modes = (
			octalmode,  # 0
			symbolicmode,  # 1
			_("%s (%s)") % (octalmode, symbolicmode)  # 2
		)

		if stat.S_ISCHR(st.st_mode) or stat.S_ISBLK(st.st_mode):
			sizes = ("", "", "")
		else:
			bytesize = "%s" % "{:n}".format(st.st_size)
			scaledsize = ' '.join(self.SIZESCALER.scale(st.st_size))
			sizes = (
				bytesize,  # 10
				_("%sB") % scaledsize,  # 11
				_("%s (%sB") % (bytesize, scaledsize)  # 12
			)

		return [modes + (
			"%d" % st.st_ino, #3
			"%d, %d" % ((st.st_dev >> 8) & 0xff, st.st_dev & 0xff),  #4
			"%d" % st.st_nlink,  # 5
			"%d" % st.st_uid,  # 6
			"%s" % username(st.st_uid),  # 7
			"%d" % st.st_gid,  # 8
			"%s" % groupname(st.st_gid)  # 9
		) + sizes + (
			formatTime(st.st_mtime),  # 13
			formatTime(st.st_atime),  # 14
			formatTime(st.st_ctime)  # 15
		)]
The file size scaler is in powers of 1000, not of 1024.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 17:33

With that tuple for the TemplatedMultiContent source, this label and templated widget:

Code: Select all

<widget name="list_left_head1" font="Regular;18" position="50,70" size="570,40" zPosition="1" foregroundColor="yellow" backgroundColor="background" transparent="1"/>
<widget source="list_left_head2" render="Listbox" position="50,110" size="570,20" foregroundColor="yellow" backgroundColor="background" zPosition="1" scrollbarMode="showOnDemand" selectionDisabled="1" transparent="1" >
	<convert type="TemplatedMultiContent">
		{"template": [
			# 0   100 200 300 400 500
			# |   |   |   |   |   |
			# 00000000 1111111111111
			MultiContentEntryText(pos = (0, 0), size = (115, 20), font = 0, flags = RT_HALIGN_LEFT, text = 1), # index 1 is a symbolic mode
			MultiContentEntryText(pos = (125, 0), size = (90, 20), font = 0, flags = RT_HALIGN_RIGHT, text = 11), # index 11 is the scaled size
			MultiContentEntryText(pos = (225, 0), size = (220, 20), font = 0, flags = RT_HALIGN_LEFT, text = 13), # index 13 is the modification time
			MultiContentEntryText(pos = (455, 0), size = (50, 20), font = 0, flags = RT_HALIGN_RIGHT, text = 7), # index 7 is the text user name
			],
			"fonts": [gFont("Regular", 18)],
			"itemHeight": 20,
			"selectionEnabled": False
		}
	</convert>
</widget>
Give this heading:
Screen Shot 2018-07-28 at 17.28.32.png
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Sat Jul 28, 2018 18:15

I think the gap between size and time should be slightly larger, and it looks like you've chopped off the time by a couple of pixels.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 18:20

adoxa wrote:
Sat Jul 28, 2018 18:15
I think the gap between size and time should be slightly larger, and it looks like you've chopped off the time by a couple of pixels.

Agreed on both counts. It's still all in "working prototype" state at the moment.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Sat Jul 28, 2018 19:12

Hi Prl,

The code and format presented look fine. Thank you for your efforts.

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 19:51

Thanks.

So, what fields do we want in the headers?
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Sat Jul 28, 2018 20:17

Hi Prl,

I would like to see the mode, date and size, in that order, by default. If the file was a media file then a duration would be handy.

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 21:05

My principle for displaying the file stat info is not modifying the file stat info. Getting the media duration involves reading a file and updating its access time.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Sat Jul 28, 2018 21:35

Hi Prl,
prl wrote:
Sat Jul 28, 2018 21:05
My principle for displaying the file stat info is not modifying the file stat info. Getting the media duration involves reading a file and updating its access time.
The request was for "handy" information. Changing the file to get the information is not "handy". :)

Regards,
ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Sat Jul 28, 2018 23:30

prl wrote:
Sat Jul 28, 2018 18:20
adoxa wrote:
Sat Jul 28, 2018 18:15
I think the gap between size and time should be slightly larger, and it looks like you've chopped off the time by a couple of pixels.

Agreed on both counts. It's still all in "working prototype" state at the moment.

The modification time needed to be pushed out a bit further to accommodate AM/PM times, too.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Mon Jul 30, 2018 11:45

Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: FileCommander.Inputmod & InputBoxmod

Post by Grumpy_Geoff » Mon Jul 30, 2018 20:41

adoxa wrote:
Fri Jul 27, 2018 12:58
prl wrote:
Sat Jul 14, 2018 16:26
It doesn't look like mediainfo is available for File Commander to use.
Here's mediainfo for the T series (tested on T2) and U4 (untested). ...

The U4 version works :)

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Tue Jul 31, 2018 15:21

Here are screen shots for the FileCommander file list headers and to add the link contents to the file status popup/screen.

File list heading (easy-skin-aus-hd, same in Full-Metal-Wizard, similar in OverlayHD, but with white rather than yellow text::
Screen Shot 2018-07-31 at 15.07.13.png

File status popup (easy-skin-aus-hd & Full-Metal-Wizard):
Screen Shot 2018-07-31 at 15.07.53.png

File status screen (OverlayHD):
1_0_1_827_807_320C_EEEE0000_0_0_0.jpg

The pinstripe separator in the file status can be either always there or only present when there for symbolic links. I've implemented both, it's just a matter of removing the unwanted one from the code & skin.

What do people think?
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: FileCommander.Inputmod & InputBoxmod

Post by Grumpy_Geoff » Tue Jul 31, 2018 15:30

I'd vote for "The pinstripe separator in the file status ... only present when there for symbolic links."

Looks good.

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Tue Jul 31, 2018 15:38

Hi Prl,

Thank you for the header attribute reorder. :)

I would prefer the pinstripe to be hidden if the extra data is not available. (I assume this will be via the ConditionalShowHide converter.)

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Tue Jul 31, 2018 15:49

IanSav wrote:
Tue Jul 31, 2018 15:38
I would prefer the pinstripe to be hidden if the extra data is not available. (I assume this will be via the ConditionalShowHide converter.)

No, it's via hide()/show() on a pinstripe-coloured background Label widget that never contains any text. I can't think of a reason to use a more complicated render chain.

Skin:

Code: Select all

<widget name="link_sep"  position="10,335" size="525,2" backgroundColor="darkgrey" transparent="0"/>
Python:

Code: Select all

		self["link_sep"] = Label()
		...
		if stat.S_ISLNK(mode):
			self["link_sep"].show()
			...
		else:
			self["link_sep"].hide()
			...
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Tue Jul 31, 2018 16:38

Hi prl,

Okay. What you propose is fine. (I was worried that it was going to be a screen element harded coded in the Python code. This has been done in some of the networking code and it really irks me.)

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Tue Jul 31, 2018 17:21

There's an error in the skin for the file status screen in the OverlayHD example. The link contents label should be full width and not wrap in the way that's shown there. Copy-paste error from the builtin skins.

I've also made the link contents area in the built-in skins 3 lines now instead of 2, because it's a lot narrower that the field in OverlayHD.

I'm going to do some final testing and I hope to submit it all this evening.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Tue Jul 31, 2018 18:06

Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Tue Jul 31, 2018 18:56

Hi Prl,

I jumped the gun and installed the FileCommander skin changes onto my test machine and wondered why all the headings went away. I suppose I should wait until the code is available if I want to see the new skin work! :P

Regards,
Ian.

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Tue Jul 31, 2018 20:18

Hi Prl,

Looking at the changes for FileCommander so far I think we can achieve another optimisation.

The screens FileCommanderScreen and FileCommanderScreenFileSelect are effectively identical. They only differ in the buttons that are enabled (the former has the MENU button while the latter does not). I think these screens, and the new panel you suggested, can be combined into a single screen. Using the auto button code suggested in BUTTONGUIDE we could have the MENU button, and the others, appear automatically in the skin without needing specific screens or specific button enabling panels.

If this is beyond the scope of your changes I will look at making the changes when your changes are merged and as soon as time permits.

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 16:21


Peteru requested some changes to the submissions (the main one was to split a large commit into steps). I've done that and re-submitted.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Wed Aug 01, 2018 16:36

Could we have rename and delete (file) use rename and remove functions instead of mv and rm consoles?

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 17:47

adoxa wrote:
Wed Aug 01, 2018 16:36
Could we have rename and delete (file) use rename and remove functions instead of mv and rm consoles?
No issue with doing it for rename. Removes tend to use a background remover of some sort, rather than a command. It shouldn't be an issue to do a remove() on a file. I'm not sure about using it on a directory tree, though it will in fact be faster than using rm.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 17:51

Display of the link indicator on links to files as well as to directories:
Screen Shot 2018-08-01 at 17.49.35.png
Screen Shot 2018-08-01 at 17.50.00.png
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 18:00

Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Wed Aug 01, 2018 18:31

prl wrote:
Wed Aug 01, 2018 17:47
Removes tend to use a background remover of some sort, rather than a command. It shouldn't be an issue to do a remove() on a file. I'm not sure about using it on a directory tree, though it will in fact be faster than using rm.
It's funny that a normal file delete goes through rm, but a multi-selection file delete goes through remove. Not sure about removing a directory - there's shutil.rmtree ... ah! which is used by DeleteFolderTask, so that should probably be used, to go with the move and copy tasks.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 20:06

There's also the C++ eBackgroundFileEraser, which is used for some remove operations in MovieSelection. There are far too many "standard" ways of removing files in enigma2.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Wed Aug 01, 2018 20:07

adoxa wrote:
Wed Aug 01, 2018 18:31
prl wrote:
Wed Aug 01, 2018 17:47
Removes tend to use a background remover of some sort, rather than a command. It shouldn't be an issue to do a remove() on a file. I'm not sure about using it on a directory tree, though it will in fact be faster than using rm.
It's funny that a normal file delete goes through rm, but a multi-selection file delete goes through remove. Not sure about removing a directory - there's shutil.rmtree ... ah! which is used by DeleteFolderTask, so that should probably be used, to go with the move and copy tasks.

Using that has the downside of adding an operation where the file list won't be updated properly after the operation (already a problem for Copy and Move).
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Thu Aug 02, 2018 10:13

Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Thu Aug 02, 2018 11:30

Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
adoxa
Wizard
Posts: 1490
Joined: Thu Feb 23, 2017 22:58
Location: CQ
Contact:

Re: FileCommander.Inputmod & InputBoxmod

Post by adoxa » Thu Aug 02, 2018 22:36

Some sort of "in progress" indicator would be nice, too. Nothing's coming to mind on just what it should be, though. There is the task list, but that's a whole other screen; I'd like to see something whilst still in the file list. Hm, would changing the title work? Or something between the two headers?

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Thu Aug 02, 2018 23:29

Hi Prl,

I would like to ask how you feel about moving the tasks function off the INFO button and then moving your new file information screen to INFO?

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 08:13

Hi, Ian. I'd been thinking of something like that. I'm not sure which new button to use for the Task list.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

User avatar
MrQuade
Uber Wizard
Posts: 11844
Joined: Sun Jun 24, 2007 13:40
Location: Perth

Re: FileCommander.Inputmod & InputBoxmod

Post by MrQuade » Fri Aug 03, 2018 08:20

prl wrote:
Fri Aug 03, 2018 08:13
Hi, Ian. I'd been thinking of something like that. I'm not sure which new button to use for the Task list.
Is TIMER currently used for anything?
Logitech Harmony Ultimate+Elite RCs
Beyonwiz T2/3/U4/V2, DP-S1 PVRs
Denon AVR-X3400h, LG OLED65C7T TV
QNAP TS-410 NAS, Centos File Server (Hosted under KVM)
Ubiquiti UniFi Managed LAN/WLAN, Draytek Vigor130/Asus RT-AC86U Internet
Pixel 4,5&6, iPad 3 Mobile Devices

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 11:25

MrQuade wrote:
Fri Aug 03, 2018 08:20
prl wrote:
Fri Aug 03, 2018 08:13
Hi, Ian. I'd been thinking of something like that. I'm not sure which new button to use for the Task list.
Is TIMER currently used for anything?

No.

The currently-used buttons are:
In the entry screen:
OK, EXIT, MENU, PREV, NEXT CH+, CH-, 0-7, 9, TEXT, INFO, BACK, UP, DOWN, RIGHT, LEFT, RED, GREEN, YELLOW, BLUE, MEDIA & HELP. SUBTITLES is used in the ActionMap, but its action does nothing. It appears to be intended to allow you to download subtitles for a media file from somewhere unspecified.

In the multi-select screen:
OK, EXIT, PREV, NEXT, CH+, CH-, 0, INFO, BACK, UP, DOWN, RIGHT, LEFT, RED, GREEN, YELLOW, BLUE, MEDIA & HELP.

Of course, if INFO is used for file status info, then 3 can be freed.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 11:41

adoxa wrote:
Thu Aug 02, 2018 22:36
Some sort of "in progress" indicator would be nice, too. Nothing's coming to mind on just what it should be, though. There is the task list, but that's a whole other screen; I'd like to see something whilst still in the file list. Hm, would changing the title work? Or something between the two headers?

The screen title already gets a "(*)" tag if the file lists are being filtered, and also has "(Selectmode)" added when in multi-select mode.

There's also the question of whether something similar should be done for the movie selection screen's backgrounded Delete, Move and Copy operations, and whether both screens should be updated by the completion of background file operations if they are in use, no matter which of them initiated the operation.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Fri Aug 03, 2018 11:52

Hi Prl,
prl wrote:
Fri Aug 03, 2018 08:13
Hi, Ian. I'd been thinking of something like that. I'm not sure which new button to use for the Task list.
I am okay with MrQuade's suggestion of using the TIMER button.

To be honest I don't see why the tasks function is in FileCommander in the first place. I would rather see this function get its own entry in the Tasks column of the main menu. The tasks function could still have a button in FileCommander and if so it should also get one in MovieSelection. Would you consider this as an alternative / better way to access the tasks function?

Regards,
Ian.

IanSav
Uber Wizard
Posts: 16846
Joined: Tue May 29, 2007 15:00
Location: Melbourne, Australia

Re: FileCommander.Inputmod & InputBoxmod

Post by IanSav » Fri Aug 03, 2018 11:52

Hi Prl,
prl wrote:
Fri Aug 03, 2018 11:41
There's also the question of whether something similar should be done for the movie selection screen's backgrounded Delete, Move and Copy operations, and whether both screens should be updated by the completion of background file operations if they are in use, no matter which of them initiated the operation.
SNAP!

Regards,
Ian.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 12:31

I've yet to work out whether it's feasible with a reasonable level of effort. The simplest way of doing it for individual screens is by making the screens more persistent by using instantiateDialog() instead of open() and only shutting down the screen when it had no more pending file tasks. That would mean that if you opened a screen, started a long operation (like move lots of recordings to a NAS), closed the screen and then re-opened it, the "new" open would actually be the same screen instance that still has the information about its remaining pending operations.

There are some issues about interactions between the single-operation main File Commander screen and its multi-select screen, but my larger issue is with the media selection screen, which is normally closed each time something is played. I haven't really looked at how to do the updates for task progress for that.

And then there's the issue of how one screen does updates on another (and even finds the other). The finding issue is made harder because the media selection screen can be opened from inside the media player.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: FileCommander.Inputmod & InputBoxmod

Post by Grumpy_Geoff » Fri Aug 03, 2018 12:33

IanSav wrote:
Fri Aug 03, 2018 11:52
...Would you consider this as an alternative / better way to access the tasks function?

Running and waiting tasks are also listed in the BLUE extensions menu from live TV. Perhaps the entry in the main menu could simply invoke that same function.

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 13:03

Grumpy_Geoff wrote:
Fri Aug 03, 2018 12:33
Running and waiting tasks are also listed in the BLUE extensions menu from live TV. Perhaps the entry in the main menu could simply invoke that same function.

The two ways of getting task information are different.

The task display in the BLUE extensions menu from live TV (Screens.TaskView.JobView) only shows the running task, but it allows you to do some simple operations on it. The task display in FileCommander (Screens.TaskList.TaskListScreen) shows a list of tasks, and allows you to open Screens.TaskView.JobView if you want to do anything to the selected task.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Grumpy_Geoff
Uber Wizard
Posts: 6490
Joined: Thu Mar 05, 2009 22:54
Location: Perth

Re: FileCommander.Inputmod & InputBoxmod

Post by Grumpy_Geoff » Fri Aug 03, 2018 13:27

prl wrote:
Fri Aug 03, 2018 13:03
Grumpy_Geoff wrote:
Fri Aug 03, 2018 12:33
Running and waiting tasks are also listed in the BLUE extensions menu from live TV. Perhaps the entry in the main menu could simply invoke that same function.

The two ways of getting task information are different.

The task display in the BLUE extensions menu from live TV (Screens.TaskView.JobView) only shows the running task, but it allows you to do some simple operations on it. The task display in FileCommander (Screens.TaskList.TaskListScreen) shows a list of tasks, and allows you to open Screens.TaskView.JobView if you want to do anything to the selected task.

As far as I've observed, it's the same task data just displayed differently.
Both lists have running and waiting tasks.
Both lists can then open up 'Job View'
Attachments
Tasks.png

prl
Wizard God
Posts: 32704
Joined: Tue Sep 04, 2007 13:49
Location: Canberra; Black Mountain Tower transmitters

Re: FileCommander.Inputmod & InputBoxmod

Post by prl » Fri Aug 03, 2018 16:48

Yes, I missed the fact that the BLUE button in live TV lists all the running tasks.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV

Post Reply

Return to “Developers Community”